LiJie20190102 commented on code in PR #12935:
URL: https://github.com/apache/gravitino/pull/12935#discussion_r4026430683
##########
maintenance/optimizer/src/main/java/org/apache/gravitino/maintenance/optimizer/command/OptimizerCommandContext.java:
##########
@@ -82,6 +83,16 @@ public List<NameIdentifier> parsedIdentifiers() {
return OptimizerCommandUtils.parseIdentifiers(identifiers);
}
+ /**
+ * Parses table identifiers, applying the configured default catalog to
schema-qualified names.
+ *
+ * @return normalized table identifiers
+ */
+ public List<NameIdentifier> parsedTableIdentifiers() {
Review Comment:
`UpdateStatisticsCommand` should switch to this too — it still calls
`parsedIdentifiers()`. With a default catalog configured, `update-statistics
--identifiers db.t1` silently matches nothing: records are stored normalized as
`catalog.db.t1` by `AbstractStatisticsImporter`, while the two-level CLI target
never equals them, so the command reports success with 0 records updated.
One-line switch + one regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]