lasdf1234 commented on code in PR #13676:
URL: https://github.com/apache/gravitino/pull/13676#discussion_r4215672402
##########
clients/client-python/gravitino/auth/default_oauth2_token_provider.py:
##########
@@ -43,20 +46,22 @@ class DefaultOAuth2TokenProvider(OAuth2TokenProvider):
_scope: Optional[str]
_path: Optional[str]
_token: Optional[str]
-
+ _authentication_method: OAuth2ClientAuthenticationMethod
def __init__(
self,
uri: str = None,
credential: str = None,
scope: str = None,
+ authentication_method: OAuth2ClientAuthenticationMethod =
+ OAuth2ClientAuthenticationMethod.CLIENT_SECRET_POST,
Review Comment:
Path should not be the last parameter. Could you change path' location
before authentication_method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
