ayush786hack commented on code in PR #13676:
URL: https://github.com/apache/gravitino/pull/13676#discussion_r4237175001
##########
clients/client-python/gravitino/auth/default_oauth2_token_provider.py:
##########
@@ -43,20 +46,22 @@ class DefaultOAuth2TokenProvider(OAuth2TokenProvider):
_scope: Optional[str]
_path: Optional[str]
_token: Optional[str]
-
+ _authentication_method: OAuth2ClientAuthenticationMethod
def __init__(
self,
uri: str = None,
credential: str = None,
scope: str = None,
+ authentication_method: OAuth2ClientAuthenticationMethod =
+ OAuth2ClientAuthenticationMethod.CLIENT_SECRET_POST,
path: str = None,
Review Comment:
Fixed. `authentication_method` is now keyword-only, after the existing
positional parameters `uri`, `credential`, `scope`, and `path`, preserving
compatibility with existing callers. I also updated `gvfs_utils.py` to match
the constructor's parameter order. The Python OAuth2 tests pass (9 passed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
