mchades commented on code in PR #13571:
URL: https://github.com/apache/gravitino/pull/13571#discussion_r4216500356
##########
server/src/main/java/org/apache/gravitino/server/web/rest/SemanticModelOperations.java:
##########
@@ -302,4 +365,86 @@ public Response dropSemanticModel(
OperationType.DROP, semanticModel, schema, e);
}
}
+
+ /**
+ * Exports a Semantic Model as a standalone Apache Ossie YAML or JSON
document.
+ *
+ * @param metalake The metalake name.
+ * @param catalog The catalog name.
+ * @param schema The schema name.
+ * @param semanticModel The Semantic Model name.
+ * @param format The output format, either {@code yaml} or {@code json}.
+ * @return A response containing the serialized Ossie document.
+ */
+ @GET
+ @Path("{semanticModel}/ossie")
Review Comment:
This endpoint deliberately uses `format` (default `yaml`) to select the
representation, and sets `Content-Type` accordingly.
`testExportOssieYamlAndJsonDocuments` already covers `format=json` with
`Accept: application/yaml` and expects JSON. Adding both media types to
`@Produces` would not reject that mismatch: either `Accept` value matches the
method, while the response type is explicitly set. I'd keep the
query-parameter-driven behavior here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
