yuqi1129 commented on PR #13702: URL: https://github.com/apache/gravitino/pull/13702#issuecomment-6060286852
Updated in b0bccc0ab. All three Copilot comments are addressed: - Removed the dedicated index-cleanup executor and its unbounded queue. A per-cache index lock now serializes the quiet presence check and index updates. No segment lock is acquired and no mutating Caffeine operation runs while holding this lock, so inline removal callbacks cannot recreate the original lock cycle. - Removed the extra task-submission path; removal callbacks retain exception isolation and error logging. - Added explicit `cleanUp()` before asserting eviction in the delayed-notification test. The presence check preserves the index entry when a key has been reinserted before an older removal notification arrives. Added coverage for a held segment during repeated eviction and for clear/reinsert followed by stale notifications. Validation: 107 targeted tests passed. Mutation checks confirmed the tests fail when restoring segment-lock acquisition, removing the presence check, or restoring the previous queued implementation. Independent fresh-context review found no new Blocker/Important findings. The already-running full core test command also completed successfully; Docker tests were not run. The PR description has been updated to match the implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
