laserninja commented on code in PR #13532:
URL: https://github.com/apache/gravitino/pull/13532#discussion_r4236388562
##########
server/src/main/java/org/apache/gravitino/server/web/rest/StatisticOperations.java:
##########
@@ -494,6 +479,61 @@ private static String getFormattedToPartitionName(String
toPartitionName, boolea
}
}
+ private Response writeStatistics(
+ String metalake,
+ String type,
+ String fullName,
+ StatisticsUpdateRequest request,
+ boolean merge) {
Review Comment:
Addressed in 7b4bb0d69. Replaced boolean merge with private
WriteMode.REPLACE / MERGE enums in both StatisticOperations and
StatisticManager, including all helper call sites. The public methods and
behavior are unchanged. All 22 focused tests (TestStatisticOperations and
TestStatisticManager) and formatting passed.
##########
core/src/main/java/org/apache/gravitino/stats/StatisticManager.java:
##########
@@ -424,4 +387,76 @@ public Statistic[] statistics() {
return statistics;
}
}
+
+ private void writeStatistics(
+ String metalake,
+ MetadataObject metadataObject,
+ Map<String, StatisticValue<?>> statistics,
+ boolean merge) {
Review Comment:
Addressed in 7b4bb0d69. StatisticManager.writeStatistics now takes
WriteMode, and updateStatistics / mergeStatistics pass REPLACE / MERGE
explicitly. The existing replacement, concurrent merge, and validation tests
pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
