ayush786hack commented on code in PR #13676:
URL: https://github.com/apache/gravitino/pull/13676#discussion_r4243763273
##########
clients/client-python/gravitino/filesystem/gvfs_utils.py:
##########
@@ -103,7 +103,7 @@ def create_client(
_check_auth_config(auth_type, GVFSConfig.OAUTH2_SCOPE, oauth2_scope)
oauth2_token_provider: OAuth2TokenProvider =
DefaultOAuth2TokenProvider(
- oauth2_server_uri, oauth2_credential, oauth2_path, oauth2_scope
+ oauth2_server_uri, oauth2_credential, oauth2_scope, oauth2_path
Review Comment:
Fixed. Python GVFS now reads the authentication method from
`GVFSConfig.OAUTH2_CLIENT_AUTHENTICATION_METHOD` and passes it to
`DefaultOAuth2TokenProvider`. It defaults to `client_secret_post` for backward
compatibility, while allowing users to configure `client_secret_basic`. I added
the targeted `test_oauth2_client_authentication_method` test, which passes.
Thanks for pointing this out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
