ayush786hack commented on code in PR #13676:
URL: https://github.com/apache/gravitino/pull/13676#discussion_r4243770598
##########
clients/client-java/src/main/java/org/apache/gravitino/client/DefaultOAuth2TokenProvider.java:
##########
@@ -61,6 +64,20 @@ public static class Builder
private String credential;
private String scope;
private String path;
+ private OAuth2ClientAuthenticationMethod authenticationMethod =
+ OAuth2ClientAuthenticationMethod.CLIENT_SECRET_POST;
+
+ /**
+ * Sets the OAuth2 client authentication method.
+ *
+ * @param authenticationMethod OAuth2 client authentication method.
+ * @return This Builder instance.
Review Comment:
Addressed for Java Hadoop GVFS. The new configuration property
`fs.gravitino.client.oauth2.authenticationMethod` allows users to select
`client_secret_basic`, while retaining `client_secret_post` as the default. The
focused Hadoop GVFS integration test passes. The Spark, Flink, and Trino OAuth2
bootstrap paths are not wired for selecting the authentication method in this
PR, so I documented this limitation in `docs/security/how-to-authenticate.md`.
I'll also make the limitation explicit in the PR description. Thanks for
highlighting this gap!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
