pithecuse527 commented on code in PR #13834:
URL: https://github.com/apache/gravitino/pull/13834#discussion_r4261135917
##########
core/src/main/java/org/apache/gravitino/hook/MetalakeHookDispatcher.java:
##########
@@ -105,7 +105,11 @@ public boolean dropMetalake(NameIdentifier ident, boolean
force)
throws NonEmptyEntityException, MetalakeInUseException {
// Child catalog/schema/fileset write-through secrets are cleaned when
MetalakeManager
// force-drops catalogs via CatalogManager.dropCatalog →
FilesetCatalogOperations.dropSchema.
- return dispatcher.dropMetalake(ident, force);
+ boolean dropped = dispatcher.dropMetalake(ident, force);
+ if (dropped) {
+ AuthorizationUtils.notifyEntityNameIdMappingChange(ident,
Entity.EntityType.METALAKE);
+ }
+ return dropped;
}
Review Comment:
i would keep the overloads separate because they delegate the work to
different `dispatcher.dropMetalake` overloads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
