brucearctor commented on issue #10272: URL: https://github.com/apache/gravitino/issues/10272#issuecomment-6176564571
This issue appears to already be resolved on `main` by #10440 (commit [`526b320cc`](https://github.com/apache/gravitino/commit/526b320cce8cc68c14626eb612ffec4751706897)): - `JobManager.close()` now wraps `jobExecutor.close()` in `try / finally` so `statusPullExecutor.shutdownNow()` and `cleanUpExecutor.shutdownNow()` always run: [`core/src/main/java/org/apache/gravitino/job/JobManager.java#L716-L723`](https://github.com/apache/gravitino/blob/8769b54b86c8699e2f806e2da96f1800ab6f9ceb/core/src/main/java/org/apache/gravitino/job/JobManager.java#L716-L723) - Unit test coverage added in `TestJobManager.testCloseAlwaysShutsDownExecutorsWhenJobExecutorThrows`: [`core/src/test/java/org/apache/gravitino/job/TestJobManager.java`](https://github.com/apache/gravitino/commit/526b320cce8cc68c14626eb612ffec4751706897#diff-b00f1557489056c2a01a7e7b310290e4b2b6a48148d94d7220263a7267670804) *(Note: #10440 used `Improvement : #10272` in the PR description instead of `Fixes #10272`, so GitHub didn't auto-close this ticket on merge.)* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
