yuqi1129 commented on code in PR #13872:
URL: https://github.com/apache/gravitino/pull/13872#discussion_r4291839263
##########
dev/charts/gravitino/values.yaml:
##########
@@ -504,7 +504,7 @@ additionalLog4j2Properties:
initScript: |
cp /tmp/conf/* ${GRAVITINO_HOME}/conf
echo "Start the Gravitino Server"
- /bin/bash ${GRAVITINO_HOME}/docker/docker-entrypoint.sh
+ exec /bin/bash ${GRAVITINO_HOME}/docker/docker-entrypoint.sh
Review Comment:
nit: since users who override `initScript` must keep the `exec` themselves
(as the PR description says), a one-line comment above `initScript` would make
that discoverable in all three charts, e.g.:
```yaml
## Keep "exec" on the start command so the JVM runs as PID 1 and receives
SIGTERM on pod termination.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
