LuciferYang commented on PR #13872: URL: https://github.com/apache/gravitino/pull/13872#issuecomment-6210604222
Thanks for tracing the whole chain. 1. Agreed, the description overstated it. I reworded the Why and user-facing sections: this change only lets SIGTERM reach the JVM, and the bounded cleanup and missing request draining are unchanged. Proper draining can be a follow-up. 2. Agreed. It's the same trade-off the image has had since #11272, so I'll leave tini or descendant cleanup for a follow-up. 3. I'd keep MCP out of this PR: it isn't a JVM, and I haven't checked whether `uv run` forwards SIGTERM to its child, so `exec` alone may not be enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
