yuqi1129 commented on PR #13049: URL: https://github.com/apache/gravitino/pull/13049#issuecomment-6317175893
I re-verified this PR end to end in a sandbox (`timelyflow/gravitino` as upstream, PRs from `yuqi1129/gravitino`) and pushed fixes on top (no force push). Head is now `e06279187a`. From my side it is ready to merge. ### Fixes pushed - `cd82063` Log the PR and base each suite tests against. `Required CI` uses `!cancelled()`, so a cancel settles in seconds instead of waiting about 6 minutes for a runner. - `682f5fb` Show running and failed fork jobs on the check. A fork run stays `queued` while any job waits for a runner, so the check showed queued for 20+ minutes after suites had already failed. The check is now in progress once a job starts, and its title and summary list the failed jobs with links, e.g. `Running, 8 job(s) failed so far`. - `7875e32` Keep upstream-only workflows quiet in forks. Once contributors enable Actions, `Cron Integration Test` failed daily in every fork and `auto-cherry-pick` failed on every push to a fork's `main`. - `abe5171` Detect merge conflicts once, with a trial merge (`git merge-tree`) in the eligibility job, for both PR and no-PR pushes. A conflict now fails one job with the conflicting files listed, and skips the suites; before, all 16 suites failed on checkout with the same error. - `9288c65` Retry GitHub API calls in base resolution. A transient 502 failed `build / changes` and `frontend / changes` in one full run. - `e062791` Sweep every 5 minutes instead of 15. Running checks are checked on every sweep; other PRs at most every 15 minutes, so API usage stays close to the 15-minute schedule. - `61fff11`, `8c869c1` Document Fork CI in `CONTRIBUTING.md`: setup, delay, re-running jobs, the manual **Update Fork CI Status** run for committers, and known limitations. ### Verified | Case | Result | |---|---| | Docs / code / compile error / cancel then re-run / late PR | Check mirrors the fork run in every case | | Merge conflict (PR and no-PR push) | One red eligibility job in ~20 s listing the conflicting files, suites skipped | | Running run with failed jobs | `Running, 8 job(s) failed so far` with links, then `15 job(s) failed` | | Full run of this head in `qqqttt123/gravitino` | success: 41 jobs passed, 6 skipped | | Full run touching 13 Java modules, Python client, MCP server, web and chart on current `main` | 39 passed, 6 skipped; the only failure was a flaky StarRocks Docker test unrelated to the change | | Full run mirrored to a sandbox PR | `All required suites passed`, about 6 minutes after the fork run finished | | Back-to-back sweeps | 2nd sweep checks only the running PR: 8 → 4 API calls | ### Before / after merging - Open PRs last pushed before this lands have no `Fork CI` check and stay blocked until their authors update and push again. I suggest a note to dev@ when this is merged. - `branch-*` PRs still run CI in `apache/gravitino` until this is backported. - The coverage PR comment no longer appears; coverage is in the `build / coverage` job log and artifact in the fork. - A PR that changes `.github/` changes what `Fork CI` checks; reviewers need to check those changes before trusting a green check (documented in `CONTRIBUTING.md`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
