yuqi1129 commented on code in PR #13049: URL: https://github.com/apache/gravitino/pull/13049#discussion_r4337460296
########## .github/workflows/build.yml: ########## @@ -2,20 +2,10 @@ name: build # Controls when the workflow will run on: - # Triggers the workflow on push or pull request events but only for the "main" branch - push: - branches: [ "main", "branch-*" ] - paths-ignore: - - 'docs/assets/**' - - 'web-v2/**' - pull_request: - branches: [ "main", "branch-*" ] - paths-ignore: - - 'docs/assets/**' - - 'web-v2/**' + workflow_call: Review Comment: This PR changes `.asf.yaml` to require only `Fork CI`, so the branch protection switches over when it is merged. Open PRs last pushed before that have no `Fork CI` check and need one more push (merge `main` or use Update branch); this is in `CONTRIBUTING.md`, and we will announce it on dev@ after merging. ########## .github/workflows/fork-ci-status.yml: ########## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. +# +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Fork CI Status + +on: + pull_request_target: + types: [opened, synchronize, reopened] + +permissions: + actions: read + checks: write + +jobs: + notify: + name: Notify fork CI + if: github.repository == 'apache/gravitino' + runs-on: ubuntu-slim + steps: + - name: Create fork CI check + uses: actions/github-script@v7 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + script: | + const pr = context.payload.pull_request; + const owner = pr.head.repo.owner.login; Review Comment: Handled: `fork-ci-status.yml` now checks `pr.head.repo` first and logs a warning instead of throwing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
