lasdf1234 commented on code in PR #13533: URL: https://github.com/apache/gravitino/pull/13533#discussion_r4367233866
########## docs/table-maintenance-service/optimizer-cli-reference.md: ########## @@ -572,6 +572,9 @@ Rewrite Manifests Results: Rewritten manifests: 24, Added manifests: 2 Both counts at zero indicate a successful no-op, for example when no manifests for the selected spec need rewriting. Other specs remain unchanged. +The [manifest rewrite policy](../iceberg-rewrite-manifests-policy.md) evaluates fresh per-spec Review Comment: **Low (docs):** Please also update the "How to find `spec_id`" paragraph a few lines above (currently around line 512). It still says to read `default-spec-id` from Iceberg metadata JSON and that these "are Iceberg table metadata fields, not Gravitino catalog properties". This PR projects `TableMetadata.defaultSpecId()` as the reserved, read-only Gravitino table property `default-spec-id` (same pattern as `current-snapshot-id`), and the policy / catalog docs already describe that. Suggested rewording for that paragraph: > Omit `spec_id` for routine maintenance of the current partition spec. Do not guess IDs such as `0` or `1`. Read the reserved Gravitino table property `default-spec-id` for the current default. Use the `partition-specs` array in the table's Iceberg metadata JSON to see each `spec-id`'s partition fields and transforms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
