mchades commented on code in PR #14139:
URL: https://github.com/apache/gravitino/pull/14139#discussion_r4384646964
##########
core/src/main/java/org/apache/gravitino/storage/relational/po/SemanticModelVersionInfoPO.java:
##########
@@ -70,8 +79,7 @@ private SemanticModelVersionInfoPO(
Preconditions.checkArgument(
StringUtils.isNotBlank(semanticModelName), "Semantic Model name cannot
be empty");
Preconditions.checkArgument(
- StringUtils.isNotBlank(semanticModelDefinition),
- "Semantic Model definition cannot be empty");
+ StringUtils.isNotBlank(datasets), "Semantic Model datasets cannot be
empty");
Preconditions.checkArgument(StringUtils.isNotBlank(auditInfo), "Audit info
cannot be empty");
Review Comment:
The normal write paths serialize these fields through Jackson, and overwrite
copies those serialized values. They do not produce blank JSON strings, so no
additional validation is needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
