mchades commented on code in PR #14139:
URL: https://github.com/apache/gravitino/pull/14139#discussion_r4384647960
##########
scripts/postgresql/schema-2.0.0-postgresql.sql:
##########
@@ -1036,7 +1036,11 @@ CREATE TABLE IF NOT EXISTS semantic_model_version_info (
version INT NOT NULL,
semantic_model_name VARCHAR(128) NOT NULL,
semantic_model_comment TEXT DEFAULT NULL,
- semantic_model_definition TEXT NOT NULL,
+ datasets TEXT NOT NULL,
+ relationships TEXT DEFAULT NULL,
+ metrics TEXT DEFAULT NULL,
+ ai_context TEXT DEFAULT NULL,
+ custom_extensions TEXT DEFAULT NULL,
properties TEXT DEFAULT NULL,
audit_info TEXT NOT NULL,
Review Comment:
Targeted reads here mean selecting the `metrics` column without loading
unrelated definition fields. This requires no JSON operators or indexes. I’ll
retain the text types specified by the current design across H2, MySQL, and
PostgreSQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
