mchades commented on code in PR #14143: URL: https://github.com/apache/gravitino/pull/14143#discussion_r4390105498
########## server/src/main/java/org/apache/gravitino/server/web/rest/SemanticModelMetricOperations.java: ########## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.server.web.rest; + +import com.codahale.metrics.annotation.ResponseMetered; +import com.codahale.metrics.annotation.Timed; +import java.util.Arrays; +import java.util.HashSet; +import java.util.Set; +import javax.inject.Inject; +import javax.servlet.http.HttpServletRequest; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.Context; +import javax.ws.rs.core.Response; +import org.apache.gravitino.Entity; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.Namespace; +import org.apache.gravitino.catalog.SemanticModelDispatcher; +import org.apache.gravitino.dto.responses.EntityListResponse; +import org.apache.gravitino.dto.responses.MetricInfoListResponse; +import org.apache.gravitino.dto.semantic.SemanticModelMetricDTO; +import org.apache.gravitino.metrics.MetricNames; +import org.apache.gravitino.semantic.SemanticModelMetric; +import org.apache.gravitino.server.authorization.MetadataAuthzHelper; +import org.apache.gravitino.server.authorization.annotations.AuthorizationExpression; +import org.apache.gravitino.server.authorization.annotations.AuthorizationMetadata; +import org.apache.gravitino.server.authorization.expression.AuthorizationExpressionConstants; +import org.apache.gravitino.server.web.Utils; +import org.apache.gravitino.utils.NamespaceUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** REST discovery of metrics contained in the Semantic Models of a schema. */ +@Path("metalakes/{metalake}/catalogs/{catalog}/schemas/{schema}/semantic-model-metrics") +public class SemanticModelMetricOperations { + private static final Logger LOG = LoggerFactory.getLogger(SemanticModelMetricOperations.class); + + private final SemanticModelDispatcher dispatcher; + @Context private HttpServletRequest httpRequest; + + /** + * Creates schema-level metric discovery operations. + * + * @param dispatcher The Semantic Model dispatcher. + */ + @Inject + public SemanticModelMetricOperations(SemanticModelDispatcher dispatcher) { + this.dispatcher = dispatcher; + } + + /** + * Lists metric identifiers or complete definitions visible to the caller. + * + * @param metalake The metalake name. + * @param catalog The catalog name. + * @param schema The schema name. + * @param details Whether to return complete metric definitions. + * @return An identifier list or metric info list response. + */ + @GET + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "list-semantic-model-metrics." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "list-semantic-model-metrics", absolute = true) + @AuthorizationExpression( + expression = AuthorizationExpressionConstants.LOAD_SCHEMA_AUTHORIZATION_EXPRESSION, + accessMetadataType = MetadataObject.Type.SCHEMA) + public Response listMetrics( + @PathParam("metalake") @AuthorizationMetadata(type = Entity.EntityType.METALAKE) + String metalake, + @PathParam("catalog") @AuthorizationMetadata(type = Entity.EntityType.CATALOG) String catalog, + @PathParam("schema") @AuthorizationMetadata(type = Entity.EntityType.SCHEMA) String schema, + @QueryParam("details") @DefaultValue("false") boolean details) { + LOG.info( + "Received list Semantic Model metrics request for {}.{}.{}, details: {}", + metalake, + catalog, + schema, + details); + try { + return Utils.doAs( + httpRequest, + () -> { + Namespace namespace = NamespaceUtil.ofSemanticModel(metalake, catalog, schema); + if (!details) { + NameIdentifier[] identifiers = dispatcher.listMetrics(namespace); + identifiers = identifiers == null ? new NameIdentifier[0] : identifiers; + Set<NameIdentifier> visibleModels = + visibleModels( + metalake, + Arrays.stream(identifiers) + .map(ident -> NameIdentifier.of(ident.namespace().levels())) + .toArray(NameIdentifier[]::new)); + NameIdentifier[] visible = + Arrays.stream(identifiers) + .filter( + ident -> + visibleModels.contains(NameIdentifier.of(ident.namespace().levels()))) + .toArray(NameIdentifier[]::new); + return Utils.ok(new EntityListResponse(visible)); + } + + SemanticModelMetric[] metrics = dispatcher.listMetricInfos(namespace); + metrics = metrics == null ? new SemanticModelMetric[0] : metrics; + Set<NameIdentifier> visibleModels = + visibleModels( + metalake, + Arrays.stream(metrics) + .map(info -> NameIdentifier.of(info.namespace().levels())) + .toArray(NameIdentifier[]::new)); + SemanticModelMetricDTO[] visible = + Arrays.stream(metrics) + .filter( + info -> + visibleModels.contains(NameIdentifier.of(info.namespace().levels()))) + .map(SemanticModelMetricDTO::fromSemanticModelMetric) + .toArray(SemanticModelMetricDTO[]::new); + return Utils.ok(new MetricInfoListResponse(visible)); + }); + } catch (Exception e) { + return ExceptionHandlers.handleSemanticModelException(OperationType.LIST, "", schema, e); Review Comment: This follows the existing REST behavior, including `listFunctionInfos`: definitions are read before visibility filtering, and internal errors retain exception details. I suggest addressing sanitization consistently in the shared error-handling layer as a separate change, keeping this PR aligned with the existing behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
