yuqi1129 commented on PR #14632: URL: https://github.com/apache/gravitino/pull/14632#issuecomment-6674015995
Addressed all four points in 0b3a146a5628d4f912389b378c7c157828bed82a: 1. Default parsing now matches complete supported literals only. Function/compound defaults remain `UnparsedExpression`; CREATE, ADD COLUMN, and SET DEFAULT tests verify readback and the values produced by PostgreSQL. 2. Metadata reads now use the same connection’s cached string mode, through pgJDBC’s literal escaper, to normalize complete backslash literals before decoding. This adds no SQL or session-setting changes. Explicit `E` escaping remains on writes. Regression tests cover both modes, multiple columns, quotes, newlines, and one/two backslashes on PostgreSQL 13 and 16. 3. The single-type guard now accepts identifier modifiers such as `geometry(Point,4326)`, `national character(3)`, and `ARRAY`, while continuing to reject extra DDL clauses. PostGIS forms are converter-tested; a PostGIS extension instance was not exercised. 4. The shared table documentation and PR description now identify the affected JDBC catalogs, ClickHouse’s separate path, Hologres’s existing raw-expression path, and PostgreSQL-specific type guards. They also clarify that StarRocks does not support ExternalType writes. Validation: 139 targeted cases passed; the 51 table-operation cases also passed against PostgreSQL 16. Six regression cases were confirmed to fail before the fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
