yuqi1129 commented on PR #14632: URL: https://github.com/apache/gravitino/pull/14632#issuecomment-6676401836
@diqiu50 A few updates since my last reply: 1. Fork CI failed `CatalogPostgreSqlIT.testColumnDefaultValueConverter`. PostgreSQL shows `varchar(20) DEFAULT (10)` as an unquoted `10`, and the stricter parser loaded it as an `UnparsedExpression`. Fixed in b3d316727f and 8354e49717: a plain number or `true`/`false` on a string column now loads as a string. An unquoted `CURRENT_TIMESTAMP` loads as the current-timestamp default on any column type. In the IT, `current_date` on a varchar column now loads as an expression, not the string `CURRENT_DATE`. 2. Merged main (#14609) and resolved the conflicts in 23e1d6e174. The PostgreSQL bytea default rendering from #14609 is kept. 3. Doc wording and one more test case in 4309a74669. Tests: the PostgreSQL converter, table-operation, and SQL-generation tests, plus the full `CatalogPostgreSqlIT`, pass locally on PostgreSQL 13. The default-value IT also passes on PostgreSQL 12 and 16. Out of scope: Hologres does not override the binary default rendering, so a bytea default is written as `X'..'`. In PostgreSQL syntax that is a bit string. This comes from the Hologres converter, not from this PR, so I will handle it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
