mchades commented on code in PR #14667:
URL: https://github.com/apache/gravitino/pull/14667#discussion_r4488364304
##########
docs/open-api/filesets.yaml:
##########
@@ -51,9 +53,27 @@ paths:
examples:
FilesetCreateRequest:
$ref: "#/components/examples/FilesetCreateRequest"
+ MultipleLocationsFilesetCreateRequest:
+ $ref:
"#/components/examples/MultipleLocationsFilesetCreateRequest"
responses:
"200":
$ref: "#/components/responses/FilesetResponse"
+ "400":
+ description: >-
+ Bad Request - The fileset creation request is invalid. For
multiple storage
+ locations, properties.default-location-name must name one of the
location keys.
+ content:
+ application/json:
+ schema:
+ $ref: "./openapi.yaml#/components/schemas/ErrorModel"
+ example:
+ code: 1001
+ type: IllegalArgumentException
+ message: >-
+ The fileset property default-location-name must be set and
must be one of
+ the fileset locations, location names: [primary, secondary],
default location name: null
Review Comment:
Extracted the response into `FilesetCreateBadRequestResponse` and referenced
it from `createFileset`, preserving the existing description and
fileset-specific validation example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]