mchades commented on code in PR #14667:
URL: https://github.com/apache/gravitino/pull/14667#discussion_r4488360394
##########
docs/open-api/filesets.yaml:
##########
@@ -348,17 +403,32 @@ components:
nullable: true
storageLocations:
type: object
- description: The storage locations of the fileset. If the storage
location of managed fileset is empty, \
- it will use the location of namespace. The storage locations of
external fileset must be set.
+ description: >-
+ The named storage locations of the fileset. If the storage
location of a managed
+ fileset is empty, it uses the location of the namespace. External
filesets must
+ specify storage locations. When the resulting fileset has more
than one location,
+ including inherited locations, properties must include
default-location-name
+ with a value matching one of the resolved location keys.
nullable: true
default: { }
additionalProperties:
type: string
properties:
type: object
- description: The properties of the fileset. Can be empty.
+ description: >-
+ The properties of the fileset. When the resulting fileset has
multiple storage locations,
+ default-location-name is required and must match one of the
resolved location keys;
+ otherwise creation returns HTTP 400. Managed filesets may inherit
locations from the
+ catalog or schema even when storageLocations is omitted.
Review Comment:
Updated the descriptions to use `schema` consistently and clarify
per-location-name precedence: request > schema > catalog. Other inherited
location names are retained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]