roryqi commented on code in PR #14482:
URL: https://github.com/apache/gravitino/pull/14482#discussion_r4465100399
##########
server-common/src/main/java/org/apache/gravitino/server/web/filter/BaseMetadataAuthorizationMethodInterceptor.java:
##########
@@ -123,6 +123,18 @@ protected interface AuthorizationHandler {
* standard expression-based authorization
*/
boolean authorizationCompleted();
+
+ /**
+ * Returns the entity type this handler authorizes the request against,
used to attribute
+ * denials and audit events. Called after {@link #process}, also when it
fails.
+ *
+ * @param defaultType entity type resolved from the method annotation
+ * @return the effective access entity type, {@code defaultType} unless
the handler targets a
+ * different object
+ */
+ default Entity.EntityType entityType(Entity.EntityType defaultType) {
Review Comment:
Why do we still need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
