[
https://issues.apache.org/jira/browse/GUACAMOLE-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311342#comment-15311342
]
ASF GitHub Bot commented on GUACAMOLE-25:
-----------------------------------------
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/12
GUACAMOLE-25: Add audio input support to RDP
Yes, it is a very large change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-server
rdp-audio-input
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/12.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12
----
commit 21ab9d765da8c0b519d6aa7c90813adf4fb9705e
Author: Michael Jumper <[email protected]>
Date: 2016-04-16T22:54:26Z
GUACAMOLE-25: Add stub "guacai" plugin for AUDIO_INPUT channel support.
commit 36cc9f492fb0424d32aaa041383d8e8ab8e3cd90
Author: Michael Jumper <[email protected]>
Date: 2016-04-17T00:13:39Z
GUACAMOLE-25: Convert guac_client pointer to/from a string for sake of
FreeRDP's DVC API.
commit 4fdcfebf2548161d771e430bead6ce7c29a3fc98
Author: Michael Jumper <[email protected]>
Date: 2016-04-17T04:42:31Z
GUACAMOLE-25: Set AudioCapture flag if audio input is enabled.
commit 9cd89e6580615249cb0dbd8773934b871bc0ddb0
Author: Michael Jumper <[email protected]>
Date: 2016-04-17T04:44:14Z
GUACAMOLE-25: Allocate proper number of argument entries.
commit ac94fd4cd02f819cceb66206d6216e12c3ab93e2
Author: Michael Jumper <[email protected]>
Date: 2016-04-17T05:48:27Z
GUACAMOLE-25: Add stub callbacks for AUDIO_INPUT data handling.
commit 1088332376343c52ca6c66fbd2053146e5b72d22
Author: Michael Jumper <[email protected]>
Date: 2016-04-17T06:28:50Z
GUACAMOLE-25: Add support for multiple versions of
IWTSVirtualChannelCallback.
commit 503ffb0d450a8dde8da4faff5fc65551ef4f1376
Author: Michael Jumper <[email protected]>
Date: 2016-04-17T08:00:42Z
GUACAMOLE-25: Implement message processing. Stub handlers.
commit 86806a37592624707aaa7450f6b4fe06bb1cf469
Author: Michael Jumper <[email protected]>
Date: 2016-04-17T09:11:29Z
GUACAMOLE-25: Handle the server's Sound Formats PDU.
commit 63cd2ce512a92a31f497d09d5e1903aeab57fd8f
Author: Michael Jumper <[email protected]>
Date: 2016-04-17T09:36:32Z
GUACAMOLE-25: Partially handle the Open PDU.
commit 9d5871a3c8a9af7522beed65d80f7630cc90f7a7
Author: Michael Jumper <[email protected]>
Date: 2016-04-18T07:32:51Z
GUACAMOLE-25: Buffer and send Data PDUs as necessary.
commit 4e4dbd6a2d9e882a2a23baf758a209621b5334fc
Author: Michael Jumper <[email protected]>
Date: 2016-04-21T05:02:01Z
GUACAMOLE-25: Fix configure test for FreeRDP variations.
commit 166eba11b728ffa4501bea9d0ad7afaf9a755911
Author: Michael Jumper <[email protected]>
Date: 2016-05-01T07:04:40Z
GUACAMOLE-25: Fix pointer update in audio input buffer transfer.
commit 5030c0603a9d8aa4a65c31afcb20e50ca71136f4
Author: Michael Jumper <[email protected]>
Date: 2016-05-02T07:09:17Z
GUACAMOLE-25: Add status code reporting the normal closure of a resource.
commit 46bdf0692fca50d74c964701f163cc0df58ba76b
Author: Michael Jumper <[email protected]>
Date: 2016-05-02T07:11:38Z
GUACAMOLE-25: Delay sending of "ack" until RDP has opened the AUDIO_INPUT
stream. Close audio stream with another "ack" when RDP has closed the
AUDIO_INPUT stream.
commit 13933584691f20c7d88294ac41aa6dd4c4f8bf04
Author: Michael Jumper <[email protected]>
Date: 2016-05-10T01:20:04Z
GUACAMOLE-25: Abstract DVC management away from FreeRDP for sake of API
compatibility.
commit f1d4393eb8cedeec0214c497c73a528806ae2118
Author: Michael Jumper <[email protected]>
Date: 2016-05-10T05:18:49Z
GUACAMOLE-25: Implement buffer attachment in Stream_New() and Stream_Free()
compatibility functions.
commit 8ccf61e6b1d9198b073b17f5bafe96e12ca65c06
Author: Michael Jumper <[email protected]>
Date: 2016-05-10T05:23:46Z
GUACAMOLE-25: Support FreeRDP stable-1.0 and compatible.
commit 320f564daf2e67ce2e746b1b5697320dc191815f
Author: Michael Jumper <[email protected]>
Date: 2016-05-11T20:34:29Z
GUACAMOLE-25: Implement parsing of audio mimetypes.
commit 533a47f06da3559ab66161fe8af8f431add167f0
Author: Michael Jumper <[email protected]>
Date: 2016-05-11T20:48:40Z
GUACAMOLE-25: Store input and output audio format.
commit 260d0cd340f78c91dd29acd6de97bf57f2e46cc9
Author: Michael Jumper <[email protected]>
Date: 2016-05-11T21:09:48Z
GUACAMOLE-25: Remove STUB.
commit ad00cce0ad882e8e549c74212cf33826ea44c4e1
Author: Michael Jumper <[email protected]>
Date: 2016-05-25T21:38:22Z
GUACAMOLE-25: Store audio format within common structure.
commit 1c2890b47c77b324efb6420df43998eff7104333
Author: Michael Jumper <[email protected]>
Date: 2016-05-26T17:39:33Z
GUACAMOLE-25: Store PCM format expected by RDP server.
commit 0be04ea54d0ce8dea9c57d29da15249b7c2db1f3
Author: Michael Jumper <[email protected]>
Date: 2016-06-01T22:25:42Z
GUACAMOLE-25: Resample received audio as necessary.
commit 0d29694afc2c7eb1fa8a8fea011bd5a7ec9a99ac
Author: Michael Jumper <[email protected]>
Date: 2016-06-01T23:20:38Z
GUACAMOLE-25: Reset I/O counters upon end-of-stream.
----
> Add support for audio input
> ---------------------------
>
> Key: GUACAMOLE-25
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-25
> Project: Guacamole
> Issue Type: New Feature
> Components: guacamole, guacamole-common-js, libguac, RDP
> Reporter: Michael Jumper
> Assignee: Michael Jumper
> Fix For: 0.9.10-incubating
>
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from
> [GUAC-1511|https://glyptodon.org/jira/browse/GUAC-1511], an issue in the JIRA
> instance used by the Guacamole project prior to its acceptance into the
> Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance
> *have not been copied* and can be found instead at the original issue.
> {panel}
> Guacamole's protocol does already technically support audio streams in either
> direction, but this is only currently implemented in the server-to-client
> direction. The same support can be added such that client-to-server audio
> streams are initiated automatically (when enabled).
> The procedure could be as follows:
> # Guacamole client attempts to create an audio stream be sending an "audio"
> instruction to the server.
> # If audio input is supported and enabled, the server responds with an "ack"
> instruction indicating success. The Guacamole client then requests access to
> the microphone via JavaScript.
> # The browser prompts the user for access if they have not already
> granted/denied it. If access is granted, the audio stream begins. If access
> is denied, the audio stream is simply closed.
> This would require adding support for RDP's audio input channel (not part of
> RDPSND, but very similar). The same could no doubt also be done for
> PulseAudio.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
