[
https://issues.apache.org/jira/browse/GUACAMOLE-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311442#comment-15311442
]
ASF GitHub Bot commented on GUACAMOLE-25:
-----------------------------------------
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/12
GUACAMOLE-25: Add "enable-audio-input" parameter for RDP.
The significantly-simpler sibling of apache/incubator-guacamole-server#12.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client
rdp-audio-input
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/12.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12
----
commit 089b584d27235c5244540fb58d90450f6ef7cbf9
Author: Michael Jumper <[email protected]>
Date: 2016-04-16T22:47:31Z
GUACAMOLE-25: Add "enable-audio-input" parameter for RDP.
----
> Add support for audio input
> ---------------------------
>
> Key: GUACAMOLE-25
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-25
> Project: Guacamole
> Issue Type: New Feature
> Components: guacamole, guacamole-common-js, libguac, RDP
> Reporter: Michael Jumper
> Assignee: Michael Jumper
> Fix For: 0.9.10-incubating
>
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from
> [GUAC-1511|https://glyptodon.org/jira/browse/GUAC-1511], an issue in the JIRA
> instance used by the Guacamole project prior to its acceptance into the
> Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance
> *have not been copied* and can be found instead at the original issue.
> {panel}
> Guacamole's protocol does already technically support audio streams in either
> direction, but this is only currently implemented in the server-to-client
> direction. The same support can be added such that client-to-server audio
> streams are initiated automatically (when enabled).
> The procedure could be as follows:
> # Guacamole client attempts to create an audio stream be sending an "audio"
> instruction to the server.
> # If audio input is supported and enabled, the server responds with an "ack"
> instruction indicating success. The Guacamole client then requests access to
> the microphone via JavaScript.
> # The browser prompts the user for access if they have not already
> granted/denied it. If access is granted, the audio stream begins. If access
> is denied, the audio stream is simply closed.
> This would require adding support for RDP's audio input channel (not part of
> RDPSND, but very similar). The same could no doubt also be done for
> PulseAudio.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
