[
https://issues.apache.org/jira/browse/GUACAMOLE-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313259#comment-15313259
]
ASF GitHub Bot commented on GUACAMOLE-44:
-----------------------------------------
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/14#discussion_r65634557
--- Diff: guacamole-common-js/src/main/webapp/modules/ArrayBufferWriter.js
---
@@ -62,6 +62,20 @@ Guacamole.ArrayBufferWriter = function(stream) {
}
/**
+ * The maximum length of any blob sent by this
Guacamole.ArrayBufferWriter,
+ * in bytes. Data sent via
+ * {@link Guacamole.ArrayBufferWriter#sendData|sendData()} which
exceeds
--- End diff --
It's the way you provide text for JSDoc3's `@link`:
http://usejsdoc.org/tags-inline-link.html
Re-reading the above ... it looks like there's a more readable, more
markdown-y syntax available. Perhaps I should switch over to that before
precedent is set?
I believe this is our first use of `@link` in the docs.
> Upload/download of files that are more than 1 GB fail
> -----------------------------------------------------
>
> Key: GUACAMOLE-44
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-44
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole
> Reporter: Michael Jumper
> Assignee: Michael Jumper
> Fix For: 0.9.10-incubating
>
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from
> [GUAC-784|https://glyptodon.org/jira/browse/GUAC-784], an issue in the JIRA
> instance used by the Guacamole project prior to its acceptance into the
> Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance
> *have not been copied* and can be found instead at the original issue.
> {panel}
> From Chrome, after attempting upload of a file greater than 1 GB in size:
> {code:none}
> Uncaught TypeError: Cannot read property 'length' of null client-ui.js:1525
> _upload_file.reader.onloadend
> {code}
> Uploading this file via Firefox simply crashes the browser. The same issue
> will occur for file downloads, as Guacamole always creates the entire file in
> memory before starting the transfer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
