[ 
https://issues.apache.org/jira/browse/GUACAMOLE-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316730#comment-15316730
 ] 

ASF GitHub Bot commented on GUACAMOLE-44:
-----------------------------------------

Github user jmuehlner commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/16#discussion_r65923641
  
    --- Diff: 
guacamole/src/main/java/org/apache/guacamole/tunnel/GuacamoleStreamException.java
 ---
    @@ -0,0 +1,61 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.guacamole.tunnel;
    +
    +import org.apache.guacamole.GuacamoleServerException;
    +import org.apache.guacamole.protocol.GuacamoleStatus;
    +
    +/**
    + * A generic exception thrown when an intercepted Guacamole stream has 
closed
    + * with an error condition. Guacamole streams report errors using the "ack"
    + * instruction, which provides a status code and human-readable message.
    + *
    + * @author Michael Jumper
    + */
    +public class GuacamoleStreamException extends GuacamoleServerException {
    +
    +    /**
    +     * The error condition reported by the intercepted Guacamole stream.
    +     */
    +    private final GuacamoleStatus status;
    +
    +    /**
    +     * Creates a new GuacamoleStreamException representing an error 
returned by
    +     * an intercepted stream.
    +     *
    +     * @param status
    +     *     The status code of the error condition reported by the 
intercepted
    +     *     Guacamole stream.
    +     *
    +     * @param message
    +     *     The human readable description of the error that occurred, as
    --- End diff --
    
    "as as"


> Upload/download of files that are more than 1 GB fail
> -----------------------------------------------------
>
>                 Key: GUACAMOLE-44
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-44
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole
>            Reporter: Michael Jumper
>            Assignee: Michael Jumper
>             Fix For: 0.9.10-incubating
>
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from 
> [GUAC-784|https://glyptodon.org/jira/browse/GUAC-784], an issue in the JIRA 
> instance used by the Guacamole project prior to its acceptance into the 
> Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance 
> *have not been copied* and can be found instead at the original issue.
> {panel}
> From Chrome, after attempting upload of a file greater than 1 GB in size:
> {code:none}
> Uncaught TypeError: Cannot read property 'length' of null client-ui.js:1525
> _upload_file.reader.onloadend
> {code}
> Uploading this file via Firefox simply crashes the browser. The same issue 
> will occur for file downloads, as Guacamole always creates the entire file in 
> memory before starting the transfer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to