[
https://issues.apache.org/jira/browse/GUACAMOLE-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334769#comment-15334769
]
ASF GitHub Bot commented on GUACAMOLE-25:
-----------------------------------------
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/15
GUACAMOLE-25: Refactor the RDPDR printer to synchronous operation.
This change replaces the old printing thread with a handler for the "ack"
responses sent by the client. Rather than continuously reading and sending
blobs, ignoring client responses, the handler will only read and send
additional print data when the client acknowledges that it is ready.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-server
rdp-synchronous-print
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 46f8fce8a9d3db7dd02bda6cdcfbd4594e0e140a
Author: Michael Jumper <[email protected]>
Date: 2016-06-09T20:57:22Z
GUACAMOLE-25: Refactor the RDPDR printer to synchronous operation.
----
> Add support for audio input
> ---------------------------
>
> Key: GUACAMOLE-25
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-25
> Project: Guacamole
> Issue Type: New Feature
> Components: guacamole, guacamole-common-js, libguac, RDP
> Reporter: Michael Jumper
> Assignee: Michael Jumper
> Fix For: 0.9.10-incubating
>
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from
> [GUAC-1511|https://glyptodon.org/jira/browse/GUAC-1511], an issue in the JIRA
> instance used by the Guacamole project prior to its acceptance into the
> Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance
> *have not been copied* and can be found instead at the original issue.
> {panel}
> Guacamole's protocol does already technically support audio streams in either
> direction, but this is only currently implemented in the server-to-client
> direction. The same support can be added such that client-to-server audio
> streams are initiated automatically (when enabled).
> The procedure could be as follows:
> # Guacamole client attempts to create an audio stream be sending an "audio"
> instruction to the server.
> # If audio input is supported and enabled, the server responds with an "ack"
> instruction indicating success. The Guacamole client then requests access to
> the microphone via JavaScript.
> # The browser prompts the user for access if they have not already
> granted/denied it. If access is granted, the audio stream begins. If access
> is denied, the audio stream is simply closed.
> This would require adding support for RDP's audio input channel (not part of
> RDPSND, but very similar). The same could no doubt also be done for
> PulseAudio.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
