[
https://issues.apache.org/jira/browse/GUACAMOLE-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334781#comment-15334781
]
ASF GitHub Bot commented on GUACAMOLE-44:
-----------------------------------------
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/16
GUACAMOLE-44: Refactor the RDPDR printer to synchronous operation.
This change replaces the old printing thread with a handler for the "ack"
responses sent by the client. Rather than continuously reading and sending
blobs, ignoring client responses, the handler will only read and send
additional print data when the client acknowledges that it is ready.
**NOTE:** This was originally opened as #15, but with the wrong JIRA issue
tag.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-server
rdp-synchronous-print
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit 8874e5022759eab0ae7e8a6ec73329e7704ba862
Author: Michael Jumper <[email protected]>
Date: 2016-06-09T20:57:22Z
GUACAMOLE-44: Refactor the RDPDR printer to synchronous operation.
----
> Upload/download of files that are more than 1 GB fail
> -----------------------------------------------------
>
> Key: GUACAMOLE-44
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-44
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole
> Reporter: Michael Jumper
> Assignee: Michael Jumper
> Fix For: 0.9.10-incubating
>
>
> {panel:bgColor=#FFFFEE}
> *The description of this issue was copied from
> [GUAC-784|https://glyptodon.org/jira/browse/GUAC-784], an issue in the JIRA
> instance used by the Guacamole project prior to its acceptance into the
> Apache Incubator.*
> Comments, attachments, related issues, and history from prior to acceptance
> *have not been copied* and can be found instead at the original issue.
> {panel}
> From Chrome, after attempting upload of a file greater than 1 GB in size:
> {code:none}
> Uncaught TypeError: Cannot read property 'length' of null client-ui.js:1525
> _upload_file.reader.onloadend
> {code}
> Uploading this file via Firefox simply crashes the browser. The same issue
> will occur for file downloads, as Guacamole always creates the entire file in
> memory before starting the transfer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
