HBASE-20061 HStore synchronized member variable filesCompacting should be private
Signed-off-by: Chia-Ping Tsai <[email protected]> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/1a36db14 Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/1a36db14 Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/1a36db14 Branch: refs/heads/branch-1.3 Commit: 1a36db1463b41fefb8688cb5b54083ce4745feb7 Parents: 4d6d4c3 Author: Sean Busbey <[email protected]> Authored: Fri Feb 23 14:38:03 2018 -0600 Committer: Sean Busbey <[email protected]> Committed: Sat Feb 24 11:00:45 2018 -0600 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/hbase/regionserver/HStore.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/1a36db14/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java index 62b2e30..bc6ec6c 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java @@ -167,8 +167,9 @@ public class HStore implements Store { private ScanInfo scanInfo; + // All access must be synchronized. // TODO: ideally, this should be part of storeFileManager, as we keep passing this to it. - final List<StoreFile> filesCompacting = Lists.newArrayList(); + private final List<StoreFile> filesCompacting = Lists.newArrayList(); // All access must be synchronized. private final Set<ChangedReadersObserver> changedReaderObservers =
