HBASE-20061 HStore synchronized member variable filesCompacting should be private
Signed-off-by: Chia-Ping Tsai <[email protected]> Conflicts: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/d2fe2a5a Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/d2fe2a5a Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/d2fe2a5a Branch: refs/heads/branch-1.2 Commit: d2fe2a5a98a64b944390ca7381abf4dae41b6191 Parents: 14ad071 Author: Sean Busbey <[email protected]> Authored: Fri Feb 23 14:38:03 2018 -0600 Committer: Sean Busbey <[email protected]> Committed: Sat Feb 24 11:01:21 2018 -0600 ---------------------------------------------------------------------- .../main/java/org/apache/hadoop/hbase/regionserver/HStore.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/d2fe2a5a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java index d73afb9..09cb50d 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java @@ -153,8 +153,9 @@ public class HStore implements Store { private ScanInfo scanInfo; + // All access must be synchronized. // TODO: ideally, this should be part of storeFileManager, as we keep passing this to it. - final List<StoreFile> filesCompacting = Lists.newArrayList(); + private final List<StoreFile> filesCompacting = Lists.newArrayList(); // All access must be synchronized. private final Set<ChangedReadersObserver> changedReaderObservers =
