[hbase] branch branch-2 updated: HBASE-23613 ProcedureExecutor check StuckWorkers blocked by DeadServe… (#960)

[binlijin]

This is an automated email from the ASF dual-hosted git repository.

binlijin pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2 by this push:
     new 976563e  HBASE-23613 ProcedureExecutor check StuckWorkers blocked by 
DeadServe… (#960)
976563e is described below

commit 976563e094036891f1260463dc01881e698100e3
Author: binlijin <binli...@gmail.com>
AuthorDate: Wed Dec 25 09:56:48 2019 +0800

    HBASE-23613 ProcedureExecutor check StuckWorkers blocked by DeadServe… 
(#960)
    
    Signed-off-by: stack <st...@apache.org>
    Signed-off-by: Duo Zhang <zhang...@apache.org>
---
 .../hadoop/hbase/master/assignment/AssignmentManager.java    | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
index e531d61..06aef4a 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
@@ -1176,15 +1176,9 @@ public class AssignmentManager {
         if (rsn.getState() != State.OPEN) {
           continue; // Opportunistic check, should quickly skip RITs, offline 
tables, etc.
         }
-        ServerName sn;
-        State state;
-        rsn.lock();
-        try {
-          sn = rsn.getRegionLocation();
-          state = rsn.getState();
-        } finally {
-          rsn.unlock();
-        }
+        // Do not need to acquire region state lock as this is only for 
showing metrics.
+        ServerName sn = rsn.getRegionLocation();
+        State state = rsn.getState();
         if (state != State.OPEN) {
           continue; // Mostly skipping RITs that are already being take care 
of.
         }