This is an automated email from the ASF dual-hosted git repository. binlijin pushed a commit to branch branch-2.2 in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.2 by this push: new 1bb30af HBASE-23613 ProcedureExecutor check StuckWorkers blocked by DeadServe… (#960) 1bb30af is described below commit 1bb30af858eae162aa95b847d566b1194f8c054b Author: binlijin <binli...@gmail.com> AuthorDate: Wed Dec 25 09:56:48 2019 +0800 HBASE-23613 ProcedureExecutor check StuckWorkers blocked by DeadServe… (#960) Signed-off-by: stack <st...@apache.org> Signed-off-by: Duo Zhang <zhang...@apache.org> --- .../hadoop/hbase/master/assignment/AssignmentManager.java | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java index 4b5e90c..3a45dd8 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java @@ -1176,15 +1176,9 @@ public class AssignmentManager { if (rsn.getState() != State.OPEN) { continue; // Opportunistic check, should quickly skip RITs, offline tables, etc. } - ServerName sn; - State state; - rsn.lock(); - try { - sn = rsn.getRegionLocation(); - state = rsn.getState(); - } finally { - rsn.unlock(); - } + // Do not need to acquire region state lock as this is only for showing metrics. + ServerName sn = rsn.getRegionLocation(); + State state = rsn.getState(); if (state != State.OPEN) { continue; // Mostly skipping RITs that are already being take care of. }