(hbase) branch branch-2.5 updated: HBASE-28332 Type conversion is no need in method CompactionChecker.chore() (#5653)

[zhangduo]

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch branch-2.5
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.5 by this push:
     new dfdb4c8c087 HBASE-28332 Type conversion is no need in method 
CompactionChecker.chore() (#5653)
dfdb4c8c087 is described below

commit dfdb4c8c0876ff62a0a832f2c57501799fe6c005
Author: guluo <lupeng_n...@qq.com>
AuthorDate: Fri Jan 26 18:17:22 2024 +0800

    HBASE-28332 Type conversion is no need in method CompactionChecker.chore() 
(#5653)
    
    Signed-off-by: Duo Zhang <zhang...@apache.org>
    (cherry picked from commit addb4e7fc3c0b6e486281033499b6de1f368d686)
---
 .../java/org/apache/hadoop/hbase/regionserver/HRegionServer.java   | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
index c33997c19b6..40dd64f7f35 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
@@ -1919,13 +1919,12 @@ public class HRegionServer extends Thread
 
     @Override
     protected void chore() {
-      for (Region r : this.instance.onlineRegions.values()) {
+      for (HRegion hr : this.instance.onlineRegions.values()) {
         // If region is read only or compaction is disabled at table level, 
there's no need to
         // iterate through region's stores
-        if (r == null || r.isReadOnly() || 
!r.getTableDescriptor().isCompactionEnabled()) {
+        if (hr == null || hr.isReadOnly() || 
!hr.getTableDescriptor().isCompactionEnabled()) {
           continue;
         }
-        HRegion hr = (HRegion) r;
         for (HStore s : hr.stores.values()) {
           try {
             long multiplier = s.getCompactionCheckMultiplier();
@@ -1953,7 +1952,7 @@ public class HRegionServer extends Thread
               }
             }
           } catch (IOException e) {
-            LOG.warn("Failed major compaction check on " + r, e);
+            LOG.warn("Failed major compaction check on " + hr, e);
           }
         }
       }