This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch branch-2.6
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.6 by this push:
new bb611f911f4 HBASE-28332 Type conversion is no need in method
CompactionChecker.chore() (#5653)
bb611f911f4 is described below
commit bb611f911f49423d453ac3fea59cea26c72054d9
Author: guluo <[email protected]>
AuthorDate: Fri Jan 26 18:17:22 2024 +0800
HBASE-28332 Type conversion is no need in method CompactionChecker.chore()
(#5653)
Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit addb4e7fc3c0b6e486281033499b6de1f368d686)
---
.../java/org/apache/hadoop/hbase/regionserver/HRegionServer.java | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
index 4f5c1c87e19..426c7ac25e9 100644
---
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
+++
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
@@ -1987,13 +1987,12 @@ public class HRegionServer extends Thread
@Override
protected void chore() {
- for (Region r : this.instance.onlineRegions.values()) {
+ for (HRegion hr : this.instance.onlineRegions.values()) {
// If region is read only or compaction is disabled at table level,
there's no need to
// iterate through region's stores
- if (r == null || r.isReadOnly() ||
!r.getTableDescriptor().isCompactionEnabled()) {
+ if (hr == null || hr.isReadOnly() ||
!hr.getTableDescriptor().isCompactionEnabled()) {
continue;
}
- HRegion hr = (HRegion) r;
for (HStore s : hr.stores.values()) {
try {
long multiplier = s.getCompactionCheckMultiplier();
@@ -2021,7 +2020,7 @@ public class HRegionServer extends Thread
}
}
} catch (IOException e) {
- LOG.warn("Failed major compaction check on " + r, e);
+ LOG.warn("Failed major compaction check on " + hr, e);
}
}
}