Code0x58 commented on a change in pull request #3663:
URL: https://github.com/apache/incubator-heron/pull/3663#discussion_r556081442
##########
File path: heron/executor/src/python/heron_executor.py
##########
@@ -102,6 +102,7 @@
@click.option("--topology-defn-file", required=True)
@click.option("--topology-id", required=True)
@click.option("--topology-name", required=True)
[email protected]("--enable-verbose-gc-log", required=False)
Review comment:
so you want to add a [boolean option to the click
app](https://click.palletsprojects.com/en/7.x/options/#boolean-flags), which I
think would be best as:
```suggestion
@click.option("--verbose-gc-log", is_flag=True)
```
Without the "enable" as that's implied, and using `is_flag` so that the
parser stores a bool indicating that `--verbose-gc-log` exists, rather than
requiring a parameter like `--enable-verbose-gc-log=1` then storing a string
like `"1"`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
