nicknezis commented on a change in pull request #3663:
URL: https://github.com/apache/incubator-heron/pull/3663#discussion_r557652927
##########
File path: heron/executor/tests/python/heron_executor_unittest.py
##########
@@ -157,19 +148,16 @@ def get_expected_instance_command(component_name,
instance_id, container_id):
instance_name = "container_%d_%s_%d" % (container_id, component_name,
instance_id)
return "heron_java_home/bin/java -Xmx320M -Xms320M -Xmn160M
-XX:MaxMetaspaceSize=128M " \
"-XX:MetaspaceSize=128M -XX:ReservedCodeCacheSize=64M
-XX:+PrintCommandLineFlags " \
- "-Djava.net.preferIPv4Stack=true -verbosegc " \
- "-XX:+UseConcMarkSweepGC -XX:+CMSScavengeBeforeRemark
-XX:TargetSurvivorRatio=90 " \
- "-XX:+PrintGCDetails -XX:+PrintGCTimeStamps -XX:+PrintGCDateStamps
" \
- "-XX:+PrintGCCause -XX:+UseGCLogFileRotation
-XX:NumberOfGCLogFiles=5 " \
- "-XX:GCLogFileSize=100M -XX:+PrintPromotionFailure
-XX:+PrintTenuringDistribution " \
- "-XX:+PrintHeapAtGC -XX:+HeapDumpOnOutOfMemoryError
-XX:ParallelGCThreads=4 " \
- "-Xloggc:log-files/gc.%s.log " \
+ "-Djava.net.preferIPv4Stack=true " \
+ "-XX:+UseG1GC -XX:+ParallelRefProcEnabled
-XX:+UseStringDeduplication " \
+ "-XX:MaxGCPauseMillis=100 -XX:InitiatingHeapOccupancyPercent=30 " \
+ "-XX:+HeapDumpOnOutOfMemoryError -XX:ParallelGCThreads=4 " \
Review comment:
`-Xloggc` set of flags are all related to the GC logging. In my testing,
I still saw JVM component log files in the `log-files` folder. This change
should only remove the GC specific logging (unless someone chooses to enable at
submit time).
I believe if the `verbose-gc` flag is not set, the changes I made to the
code will not set those JVM flags. This unit test is testing with the defaults,
so what you see here matches what was generated by the `heron_executor.py`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
