surahman edited a comment on pull request #3710: URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-938223306
I have made some enhancements to allow the merging of the default executor container configuration with one which is provided in the Pod Template. The Heron defaults will overwrite anything provided in the Pod Template by a user. This enhancement allows for some tweaking of the executor container specs within constraints. Only a single container is permitted per executor. This is important to avoid the launching of additional containers within a Pod. What are your thoughts? Should we be allowing the executor container to be modified? **_Edit:_** If we do want a Pod Template to be able to provide additional configs I am going to 🗑️ and 🔥 the `mergeExecutorContainer` and just modify the `getContainer`. It is a simpler and cleaner solution to just pass in the `V1Container` object when has been parsed from input and let `getContainer` overwrite with `Heron` defaults 🤦🏼♂️. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
