nicknezis commented on pull request #3710: URL: https://github.com/apache/incubator-heron/pull/3710#issuecomment-934013942
> > I think we will need to follow the same protocol and standards and document this information. Not all fields are lists or maps... Yes, and I added some logic to set labels and annotations with config properties. So no need to use PodTemplate for setting those. We should list the parts of the PodTemplate that will be replaced, and the config items that can be used to set them (i.e. Env variables, labels, annotations). For `getPodSpec()`, maybe we just always modify the `PodSpec` that exists on the PodTemplate (instead of setting a brand new `PodSpec`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
