surahman commented on a change in pull request #3797:
URL: https://github.com/apache/incubator-heron/pull/3797#discussion_r834916998
##########
File path: heron/common/src/cpp/network/event_loop_impl.cpp
##########
@@ -18,6 +18,7 @@
*/
#include "network/event_loop_impl.h"
+#include <signal.h>
Review comment:
[signals.h](https://man7.org/linux/man-pages/man0/signal.h.0p.html) has
a bunch of macros and methods for handling interrupts signals from the OS.
`SIGTERM` is one such macro.
https://github.com/apache/incubator-heron/blob/b248f767c636a0b114a7b0ba3bad433c97189303/heron/common/src/cpp/network/event_loop_impl.cpp#L86
Not certain why it would now need to now be explicitly included unless the
updates to the Protobuf mean these definitions are no longer included in one of
the other headers (compilation failures will result).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
