thinker0 commented on a change in pull request #3797:
URL: https://github.com/apache/incubator-heron/pull/3797#discussion_r834972513
##########
File path: heron/common/src/cpp/network/event_loop_impl.cpp
##########
@@ -18,6 +18,7 @@
*/
#include "network/event_loop_impl.h"
+#include <signal.h>
Review comment:
```
ERROR: /scratch/heron/common/src/cpp/network/BUILD:5:11: Compiling
heron/common/src/cpp/network/event_loop_impl.cpp failed: (Exit 1): gcc failed:
error executing command
(cd
/root/.cache/bazel/_bazel_root/c481f31d0aff7f9fd86654fb84c9a629/execroot/org_apache_heron
&& \
exec env - \
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin \
PWD=/proc/self/cwd \
/usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall
-Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0
-O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections -fdata-sections
'-std=c++0x' -MD -MF
bazel-out/k8-opt/bin/heron/common/src/cpp/network/_objs/network-cxx/event_loop_impl.d
'-frandom-seed=bazel-out/k8-opt/bin/heron/common/src/cpp/network/_objs/network-cxx/event_loop_impl.o'
-iquote . -iquote bazel-out/k8-opt/bin -iquote external/com_github_google_glog
-iquote bazel-out/k8-opt/bin/external/com_github_google_glog -iquote
external/com_github_gflags_gflags -iquote
bazel-out/k8-opt/bin/external/com_github_gflags_gflags -iquote
external/com_github_gperftools_gperftools -iquote
bazel-out/k8-opt/bin/external/com_github_gperftools_gperftools -iquote
external/com_github_corvusoft_kashmir_cpp -iquote
bazel-out/k8-opt/bin/external/com_github_corvusoft_kashmir_cpp -iquote
external/com_google_protobuf -iquote
bazel-out/k8-opt/bin/external/com_google_proto
buf -iquote external/zlib -iquote bazel-out/k8-opt/bin/external/zlib -iquote
external/org_nongnu_libunwind -iquote
bazel-out/k8-opt/bin/external/org_nongnu_libunwind -iquote
external/org_libevent_libevent -iquote
bazel-out/k8-opt/bin/external/org_libevent_libevent -isystem
external/com_github_google_glog/include -isystem
bazel-out/k8-opt/bin/external/com_github_google_glog/include -isystem
external/com_github_gflags_gflags/include -isystem
bazel-out/k8-opt/bin/external/com_github_gflags_gflags/include -isystem
external/com_github_gperftools_gperftools/include -isystem
bazel-out/k8-opt/bin/external/com_github_gperftools_gperftools/include -isystem
external/com_google_protobuf/src -isystem
bazel-out/k8-opt/bin/external/com_google_protobuf/src -isystem
external/zlib/zlib/include -isystem
bazel-out/k8-opt/bin/external/zlib/zlib/include -isystem
external/org_nongnu_libunwind/include -isystem
bazel-out/k8-opt/bin/external/org_nongnu_libunwind/include -isystem
external/org_libevent_libeven
t/include -isystem bazel-out/k8-opt/bin/external/org_libevent_libevent/include
-O3 -Iheron/common/src/cpp -Ibazel-out/k8-opt/bin/heron/common/src/cpp
-fno-canonical-system-headers -Wno-builtin-macro-redefined
'-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c
heron/common/src/cpp/network/event_loop_impl.cpp -o
bazel-out/k8-opt/bin/heron/common/src/cpp/network/_objs/network-cxx/event_loop_impl.o)
Execution platform: @local_config_platform//:host
In file included from external/org_libevent_libevent/include/event.h:69:0,
from heron/common/src/cpp/network/regevent.h:27,
from heron/common/src/cpp/network/event_loop_impl.cpp:26:
heron/common/src/cpp/network/event_loop_impl.cpp: In member function
'virtual void EventLoopImpl::loop()':
heron/common/src/cpp/network/event_loop_impl.cpp:85:50: error: 'SIGTERM' was
not declared in this scope
struct event *term = evsignal_new(mDispatcher, SIGTERM, handleTerm,
mDispatcher);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
