surahman edited a comment on pull request #3786: URL: https://github.com/apache/incubator-heron/pull/3786#issuecomment-1086915482
I will get started on the bottom end of the list of style errors to help out. Files I am looking at: Outstanding: ```bash ************* Module basics.base_instance ************* Module basics.bolt_instance ************* Module basics.spout_instance ************* Module instance ``` Completed: ```bash ************* Module network.gateway_looper ************* Module network.heron_client ************* Module network.metricsmgr_client ************* Module network.protocol ************* Module network.socket_options ************* Module utils.metrics.metrics_helper ************* Module utils.metrics.py_metrics ************* Module utils.misc.pplan_helper ************* Module utils.misc.serializer_helper ************* Module utils.topology.topology_context_impl ``` Someone with more Python3 experience should look over my work. Each file is in its own commit so that it can be dropped if problematic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
