nicknezis commented on a change in pull request #3786:
URL: https://github.com/apache/incubator-heron/pull/3786#discussion_r841261187
##########
File path: heron/instance/src/python/utils/metrics/py_metrics.py
##########
@@ -80,7 +80,7 @@ def __init__(self, metrics_collector):
PY_GC_GENERATION_1_THRESHOLD: self.g1_threshold,
PY_GC_GENERATION_2_THRESHOLD: self.g2_threshold,
PY_GC_GENERATION_3_THRESHOLD: self.g3_threshold}
- super(PyMetrics, self).__init__(self.metrics)
+ _ = super()
Review comment:
Should this have been `super().__init__(self.metrics)`? I don't know
Python well enough, but that was the recommendation I saw online. I'm not
familiar with the `_ = super()` syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
