surahman commented on code in PR #3818: URL: https://github.com/apache/incubator-heron/pull/3818#discussion_r848693933
########## heron/tools/tracker/src/python/routers/metrics.py: ########## @@ -119,6 +119,7 @@ async def get_metrics( # pylint: disable=too-many-arguments ) [email protected]("/metricstimeline", response_model=metricstimeline.MetricsTimeline) @router.get("/metrics/timeline", response_model=metricstimeline.MetricsTimeline) Review Comment: Sorry, I am not familiar with the `FastAPI` library and I have a general question about it: will this attempt to scrape both endpoints? If so, I think one of them will always return a 404 depending on the case, this will not be an issue? I tried searching and could not find any details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
