nicknezis commented on code in PR #3818: URL: https://github.com/apache/incubator-heron/pull/3818#discussion_r848914560
########## heron/tools/tracker/src/python/routers/metrics.py: ########## @@ -119,6 +119,7 @@ async def get_metrics( # pylint: disable=too-many-arguments ) [email protected]("/metricstimeline", response_model=metricstimeline.MetricsTimeline) @router.get("/metrics/timeline", response_model=metricstimeline.MetricsTimeline) Review Comment: Interesting. I didn't realize this was a feature. According to [this ticket](https://github.com/tiangolo/fastapi/discussions/4299#discussioncomment-1839922), it should work. it also mentions a `deprecated=True` flag that might be a good idea to add. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
