nwangtw commented on a change in pull request #3184: Consolidate packing code
URL: https://github.com/apache/incubator-heron/pull/3184#discussion_r253224777
##########
File path:
heron/packing/src/java/org/apache/heron/packing/utils/PackingUtils.java
##########
@@ -26,74 +26,42 @@
import org.apache.heron.api.generated.TopologyAPI;
import org.apache.heron.api.utils.TopologyUtils;
import org.apache.heron.common.basics.ByteAmount;
-import org.apache.heron.spi.packing.PackingException;
import org.apache.heron.spi.packing.Resource;
/**
* Shared utilities for packing algorithms
*/
public final class PackingUtils {
private static final Logger LOG =
Logger.getLogger(PackingUtils.class.getName());
- private static final ByteAmount MIN_RAM_PER_INSTANCE =
ByteAmount.fromMegabytes(192);
+
+ // default
+ public static final int DEFAULT_CONTAINER_PADDING_PERCENTAGE = 10;
+ public static final ByteAmount DEFAULT_CONTAINER_RAM_PADDING =
ByteAmount.fromGigabytes(1);
+ public static final ByteAmount DEFAULT_CONTAINER_DISK_PADDING =
ByteAmount.fromGigabytes(1);
+ public static final double DEFAULT_CONTAINER_CPU_PADDING = 1.0;
+ public static final int DEFAULT_MAX_NUM_INSTANCES_PER_CONTAINER = 4;
Review comment:
4 might be too small. 10 might be better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
