nwangtw commented on a change in pull request #3184: Consolidate packing code
URL: https://github.com/apache/incubator-heron/pull/3184#discussion_r253224194
##########
File path: heron/api/src/java/org/apache/heron/api/Config.java
##########
@@ -181,16 +181,24 @@
*/
public static final String TOPOLOGY_CONTAINER_MAX_DISK_HINT =
"topology.container.max.disk.hint";
/**
- * Hint for max amount of disk per container to be reserved for this
topology.
- * In bytes.
+ * Percent of resource to pad each container.
*/
public static final String TOPOLOGY_CONTAINER_PADDING_PERCENTAGE
= "topology.container.padding.percentage";
+ /**
+ * Max number of instances per container for this topology.
+ */
+ public static final String TOPOLOGY_CONTAINER_MAX_NUM_INSTANCES
Review comment:
move up or down so that padding percentage is close than the other padding
configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
