nwangtw commented on a change in pull request #3201: Enable gperftool HEAPCHECK
in integration test
URL: https://github.com/apache/incubator-heron/pull/3201#discussion_r264347068
##########
File path: heron/common/src/cpp/network/event_loop_impl.cpp
##########
@@ -76,7 +76,15 @@ EventLoopImpl::~EventLoopImpl() {
event_base_free(mDispatcher);
}
+static void handleTerm(evutil_socket_t _, sp_int16 what, void* ctx) {
Review comment:
Suggest to break this change into a different PR.
Also I am wondering if it is better to move the evsignal_new() to caller in
case multiple event loop objects are created in an application.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
