nwangtw commented on a change in pull request #3201: Enable gperftool HEAPCHECK
in integration test
URL: https://github.com/apache/incubator-heron/pull/3201#discussion_r264546651
##########
File path: heron/executor/src/python/heron_executor.py
##########
@@ -146,6 +146,38 @@ def stdout_log_fn(cmd):
# Log the messages to stdout and strip off the newline because Log.info adds
one automatically
return lambda line: Log.info("%s stdout: %s", cmd, line.rstrip('\n'))
+class Command(object):
+ """Command to run as a separate process using subprocess.POpen"""
Review comment:
might include the information that this is a data class and it contains:
- cmd is a list of strings
- env is a list of environment variables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
