nwangtw commented on a change in pull request #3282: WIP STREAMCOMP-2724:
Stream Manager migrated to mainly use smart pointers instead of a manual memory
management
URL: https://github.com/apache/incubator-heron/pull/3282#discussion_r291290742
##########
File path: heron/stmgr/src/cpp/manager/checkpoint-gateway.h
##########
@@ -85,7 +89,7 @@ class CheckpointGateway {
std::deque<Tuple> ForceDrain();
void Clear();
private:
- void add(Tuple _tuple, sp_uint64 _size);
+ void add(Tuple& _tuple, sp_uint64 _size);
void add_front(Tuple _tuple, sp_uint64 _size);
Review comment:
maybe better to be "Tuple&" too here like the function above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
